Replace the element permission check with a batch endpoint - #209
Open
flomillot wants to merge 3 commits into
Open
Replace the element permission check with a batch endpoint#209flomillot wants to merge 3 commits into
flomillot wants to merge 3 commits into
Conversation
HEAD /elements/{uuid} answered a single element with a 200 or a 403. The
new GET /elements/permission takes a list of element uuids and returns the
ones the user has the given right on, so a client resolving several
elements no longer needs one call per element.
Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 27, 2026
ghazwarhili
reviewed
Sep 7, 2026
The endpoint returns elements, not a permission, which its name now reflects, along with the path it calls on directory-server. The controller parameter is renamed permissionType, as the service it delegates to already named it, and the operation and response descriptions are reworded accordingly. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
ghazwarhili
approved these changes
Sep 9, 2026
|
etiennehomer
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on gridsuite/directory-server#267.
HEAD /explore/elements/{uuid}?permission=…answers a single element with a 200 or a 403, so a client resolving several elements needs one call per element.It is replaced by
GET /explore/elements/accessible?ids=…&accessType=…, which returns the uuids the user has the given right on, the forbidden and the unknown ones being left out. It delegates to the directory-server endpoint added in the PR above.